Added intent chooser for selecting image sources #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Canato
requested changes
Mar 7, 2022
|
branch need to be rebased for latest main |
Made IntentChooser optional
Canato
requested changes
Mar 10, 2022
|
On holidays until next week, them I'm back to this ticket ^^ Sorry for delay |
No Problem. Enjoy @Canato 🎉🎉🎊 |
|
Can you recheck @Canato I've added all the suggested changes possible |
Canato
requested changes
Mar 28, 2022
cropper/src/main/java/com/canhub/cropper/CropImageContractOptions.kt
Outdated
Show resolved
Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt
Outdated
Show resolved
Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt
Outdated
Show resolved
Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt
Outdated
Show resolved
Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt
Outdated
Show resolved
Hide resolved
cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt
Outdated
Show resolved
Hide resolved
|
All changes done |
Canato
requested changes
Apr 2, 2022
cropper/src/main/java/com/canhub/cropper/CropImageIntentChooser.kt
Outdated
Show resolved
Hide resolved
Canato
approved these changes
Apr 3, 2022
Thanks @Canato This is my first ever contribution. Technically 2nd cz of the other minor PR but 🥳🥳🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #325
Added Intent Chooser [New Feature]
Description:
This PR adds an option to show an intent chooser in place of an alert dialog. The part that triggers it is currently commented out. @Canato let me know what you think. I hope its good. I've left a screenshot below