Skip to content

Conversation

@oscar60310
Copy link
Contributor

Description

We called the next() function twice while catching errors.

2022-09-22 06:21:11.094  DEBUG [SERVE] normalize auth payload source failed, reason => Url ending format not matched in "formats" options

  Error: next() called multiple times
      at dispatch (/home/goofy/projects/vulcan/node_modules/koa-compose/index.js:36:45)
      at AuthSourceNormalizerMiddleware.<anonymous> (/home/goofy/projects/vulcan/labs/playground1/node_modules/@vulcan-sql/serve/src/lib/middleware/auth/authSourceNormalizerMiddleware.js:64:24)
      at Generator.throw (<anonymous>)
      at rejected (/home/goofy/projects/vulcan/node_modules/tslib/tslib.js:116:69)
      at processTicksAndRejections (node:internal/process/task_queues:96:5)

Issue ticket number

N/A quick fix

Additional Context

Related to #47

@oscar60310 oscar60310 requested a review from kokokuo September 22, 2022 06:31
@codecov-commenter
Copy link

Codecov Report

Base: 92.73% // Head: 92.76% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (ac534c9) compared to base (2a5e525).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #80      +/-   ##
===========================================
+ Coverage    92.73%   92.76%   +0.02%     
===========================================
  Files          229      229              
  Lines         3223     3221       -2     
  Branches       392      392              
===========================================
- Hits          2989     2988       -1     
+ Misses         168      167       -1     
  Partials        66       66              
Flag Coverage Δ
integration-testing 96.15% <ø> (ø)
serve 90.22% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../middleware/auth/authSourceNormalizerMiddleware.ts 92.85% <100.00%> (+2.85%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kokokuo kokokuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😀 Thanks for solving the issue!!

@kokokuo kokokuo merged commit 6121276 into develop Sep 22, 2022
@kokokuo kokokuo deleted the fix/fix-auth-source-middleware branch September 22, 2022 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants