Fix: Update CLI initialized files to align the new design #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscar60310
force-pushed
the
fix/align-cli
branch
from
b7c0046 to
508c3e5
Compare
Codecov ReportBase: 92.52% // Head: 92.52% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #86 +/- ##
========================================
Coverage 92.52% 92.52%
========================================
Files 245 245
Lines 3533 3533
Branches 446 446
========================================
Hits 3269 3269
Misses 179 179
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
- move build package to dev dependencies - update sample queries - add empty profiles.yaml
oscar60310
force-pushed
the
fix/align-cli
branch
from
508c3e5 to
6861677
Compare
kokokuo
approved these changes
Sep 24, 2022
Contributor
kokokuo
left a comment
kokokuo
left a comment
There was a problem hiding this comment.
LGTM 👍 Thanks for aligning to the new design and update the cli init template vulcan.yaml !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update these SQL files, schemas, and config.
Issue ticket number
closes #83
Additional Context