Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for "relation" on jujucharms.com/docs site returns Server Error #178

Closed
mbruzek opened this issue Nov 6, 2015 · 9 comments
Closed

Comments

@mbruzek
Copy link

mbruzek commented Nov 6, 2015

I am on the page https://jujucharms.com/docs/stable/getting-started and search for "relation" that returns a page that tells me a Server Error has occurred. The search term "relations" works fine, I get normal search results.

We should not return a Server Error when a term is not found in search results. Can someone help me fix this problem?
jujucharms com_server_error

@mbruzek
Copy link
Author

mbruzek commented Nov 6, 2015

More information: I search for other words that would not be in our docs such as "crazy" and that returns a results page with zero results (as I would expect).

I am very confused why "relation" returns a server error.

@mbruzek mbruzek changed the title search on docs site returns server error Search for "relation" on jujucharms.com/docs site returns Server Error Nov 6, 2015
@mitechie
Copy link
Contributor

mitechie commented Nov 9, 2015

Looks like the team has an update for this.

On Fri, Nov 6, 2015 at 2:53 PM Matt Bruzek notifications@github.com wrote:

More information: I search for other words that would not be in our docs
such as "crazy" and that returns a results page with zero results (as I
would expect).

I am very confused why "relation" returns a server error.


Reply to this email directly or view it on GitHub
#178 (comment)
.

@mbruzek
Copy link
Author

mbruzek commented Nov 9, 2015

@fabricematrat Do you have a link to the code that addresses this issue? I don't think the problem is fixed, I tried the search again today: https://jujucharms.com/docs/search/?text=relation&version=1.25 and get the Server Error page.

@bac
Copy link

bac commented Nov 9, 2015

@mbruzek The fix is being QA'd now and will land in our trunk soon. I'm not sure when it will be released to production.

@fabricematrat
Copy link

@mbruzek this is why I put fix committed not released sorry for the
confusion I will let you know as soon as it is released

On Nov 9, 2015 8:00 PM, "Brad Crittenden" notifications@github.com wrote:

@mbruzek The fix is being QA'd now and will land in our trunk soon. I'm
not sure when it will be released to production.


Reply to this email directly or view it on GitHub.

@mbruzek
Copy link
Author

mbruzek commented Dec 2, 2015

@fabricematrat How does your fix work? Is there a list of words that do not return anything? I searched today for "icon" and got the same error page. Do I need to create a separate bug for that each word I find? Can you give me some insight on why this was broken and how you fixed it?

@mbruzek
Copy link
Author

mbruzek commented Dec 2, 2015

Also "copyright" does not return a result.

@fabricematrat
Copy link

Sorry but we did not yet release to prod, this will happens most likely next week.
The error was coming from a parse and unicode error not catched.

@urosj
Copy link

urosj commented Dec 15, 2015

Fix was released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants