/subiquity

Indicate if a wired interface is connected or not #162

Merged
merged 3 commits into from Sep 20, 2016

Conversation

Reviewers

@cyphermox cyphermox

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@mwhudson @cyphermox
@mwhudson
Collaborator

mwhudson commented Sep 16, 2016

Depends on CanonicalLtd/probert#26

See https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1623897

mwhudson added some commits Sep 16, 2016

@mwhudson
Really probe (i.e. call into probert) every time we load the network … 
…screen.

Connected-ness of a link is something that can plausibly change over short
timescales.
682c81c
@mwhudson
Show if a link is not connected. 
At least as well as ip(8) does it.
f78cae6
@cyphermox

cyphermox requested changes Sep 16, 2016
View changes

Added comments inline.

subiquitycore/models/network.py
@@ -228,6 +231,12 @@ def ip6_providers(self):
ip_info = self._get_ip_info()
return ip_info['ip6_providers']
+ def is_connected(self):
@cyphermox

cyphermox Sep 16, 2016

Collaborator

I think this properly belongs in probert rather than directly in our models for subiquity.

@mwhudson

mwhudson Sep 18, 2016

Collaborator

Done.

subiquitycore/models/network.py
@@ -360,6 +369,7 @@ def get_menu(self):
# --- Model Methods ----
def probe_network(self):
log.debug('model calling prober.get_network()')
+ self.prober.probe()
@cyphermox

cyphermox Sep 16, 2016

Collaborator

Why do we need to probe again? The probing should have already happened before, at the point where we did the initial discovery of the devices.

@mwhudson

mwhudson Sep 18, 2016

Collaborator

In case the user has connected an interface since that happened. Ogra has filed https://bugs.launchpad.net/ubuntu/+source/subiquity/+bug/1624322 since I did this, so maybe I should dust of my "live updates of networking UI" code.

@mwhudson mwhudson merged commit f031e71 into master Sep 20, 2016

@mwhudson mwhudson deleted the mwhudson/link-status branch Sep 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment