add snapcraft.yaml & --extra-snaps #46

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
2 participants
Collaborator

mvo5 commented Sep 1, 2016

This adds a snapcraft.yaml file for ubuntu-image and fixes a bug where mcopy can not be found in the snap because the PATH is reset.

Note that the snap is not fully working because ubuntu-image when called without sudo. In this case the code tries to call sudo itself which will not work (yet) inside snaps because we have not the right pty available for the asking for a password.

Of couse you need to adjust the git path once its merged, I had to have this to be able to test the image.

Collaborator

mvo5 commented Sep 1, 2016

Please also note that with current master my amd64 image does not boot with just kvm test.img.

@mvo5 mvo5 changed the title from add snapcraft.yaml to add snapcraft.yaml & --extra-snaps Sep 1, 2016

Collaborator

mvo5 commented Sep 1, 2016

Sorry for the messy branch, things are in a bit of a hurry here. Happy to split this out into meaningful branches.

Collaborator

mvo5 commented Sep 1, 2016

The os.trunacte() one is super important, its the difference between a 4gb file and a much smaller file with a hole in it. This is important for our automatic image testing as the file with the hole can be fitted into RAM on our test instances but the 4gb real file can't.

@warsaw warsaw referenced this pull request Sep 2, 2016

Merged

snapcraft.yaml from mvo5 #49

Contributor

warsaw commented Sep 2, 2016

@mvo5 In what cases is $PATH reset? Do you have any additional details on why $PATH won't propagate to the child in the subprocess call?

Contributor

warsaw commented Sep 2, 2016

Is the problem that snap prepare-image should be calling unsquashfs using the full path, i.e. to /usr/bin/unsquashfs?

warsaw added a commit that referenced this pull request Sep 2, 2016

@warsaw warsaw referenced this pull request Sep 2, 2016

Merged

Supersede #46 #51

Collaborator

mvo5 commented Sep 5, 2016

@warsaw Thanks for your work on this! I followed up in the #46 PR and will close this one.

@mvo5 mvo5 closed this Sep 5, 2016

vorlonofportland added a commit that referenced this pull request Sep 6, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment