Make sure <unpack>/image/etc gets into the system-data directory #72

Merged
merged 2 commits into from Oct 12, 2016

Conversation

Projects
None yet
2 participants
Contributor

warsaw commented Oct 11, 2016

Closes LP: #1632134 and replaces #69. @mvo5

@warsaw warsaw referenced this pull request Oct 11, 2016

Closed

include etc/ as well #69

ubuntu_image/builder.py
+ for subdir in os.listdir(src):
+ # LP: #1632134 - copy everything under the image directory except
+ # /boot and /home. For now, we even copy files.
+ if subdir not in ('boot', 'home'):
@vorlonofportland

vorlonofportland Oct 11, 2016

Contributor

+1 for the /boot exclusion. Why exclude /home?

@warsaw

warsaw Oct 11, 2016

Contributor

That's a question for @mvo5 who suggested this in #69

@warsaw

warsaw Oct 11, 2016

Contributor

FWIW, there doesn't actually seem to be a /home in the pc or pi2 gadgets.

@warsaw

warsaw Oct 12, 2016

Contributor

I've thought about this more and in the absence of a motivating use case, I will not exclude /home.

@warsaw warsaw merged commit 0235db8 into master Oct 12, 2016

2 checks passed

xenial-amd64 autopkgtest finished (success)
Details
yakkety-amd64 autopkgtest finished (success)
Details

@warsaw warsaw deleted the lp1632134 branch Oct 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment