*WezTerm* supports the *Kitty* Image protocol now

[stevenxxiu]

Per wez/wezterm#986, WezTerm now supports the Kitty image protocol.

The code at

broot/src/kitty/image_renderer.rs

Line 87 in 424023b

/// until I'm told there's another terminal supporting the kitty

only checks for if term_name.contains("kitty"). This can include WezTerm now too.

[Canop]

Thanks.
I'll have a look.

[Canop]

There's more to the problem than just detecting support.
I've implemented (presumed) correct protocol detection (see https://github.com/Canop/xterm-query) but for now I can't render the images the same way. I'll try to investigate more in the next days.

[Canop]

It kind of works but I wonder if wezterm supports completely the protocol. Resizing doesn't seem to work, for example.

In Kitty:

In Wezterm:

Kitty's spec specifies that "The image will be scaled (enlarged/shrunk) as needed to fit the specified area" and Wezterm doesn't seem to respect that.

I've also another problem: the only way to correctly detect the support without having problems on some terminals seems to be to read an env var and there's no guarantee wezterm sets it in an adequate way.

[wez]

I made a comment over here: 0b15aed#r62986264 about detection

Kitty's spec specifies that "The image will be scaled (enlarged/shrunk) as needed to fit the specified area" and Wezterm doesn't seem to respect that.

For the scaling issue, can you clarify for me what's happening? Are you using the c and r keys to set the desired columns and rows for the image?

https://github.com/Canop/broot/blob/master/src/kitty/image_renderer.rs#L192-L199

[dankamongmen]

I've also another problem: the only way to correctly detect the support without having problems on some terminals seems to be to read an env var and there's no guarantee wezterm sets it in an adequate way.

i can tell you that Notcurses is detecting it via terminal query

[dankamongmen]

i can tell you that Notcurses is detecting it via terminal query

https://github.com/dankamongmen/notcurses/blob/master/src/lib/in.c#L1243-L1250
https://github.com/dankamongmen/notcurses/blob/master/src/lib/in.c#L1563
https://github.com/dankamongmen/notcurses/blob/master/src/lib/termdesc.c#L470-L481

[wez]

I've fixed the scaling issue in wezterm!

[Canop]

I confirm the fix is working :)

[Canop]

@wez Has there been a release since your fix ?

Please see #509

[wez]

Not yet; they can use the nightly build for now

[namespaceYcZ]

What's the progress now? I found image rendering still not "full quality" on the nightly wezterm and the newest broot(on Windows).