New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get service url middleware #43
Conversation
src/hooks.js
Outdated
@@ -49,6 +49,7 @@ export function locate(load) { | |||
stepMiddleware(newMiddleware, url, function(newUrl, newMiddleware) { | |||
middlewareMap[id] = newMiddleware; | |||
middlewareTracker = id; | |||
serviceMap[service] = newUrl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This happens in the resolve function, which every spot down below calls
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The resolve function is asynchronous and executed after middleware
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚶 thanks!
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
- Coverage 98% 97.97% -0.03%
==========================================
Files 6 6
Lines 300 297 -3
Branches 56 56
==========================================
- Hits 294 291 -3
Misses 6 6
Continue to review full report at Codecov.
|
Change
getServiceUrl
to respect middleware