Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copybutton functionality #98

Merged
merged 8 commits into from May 3, 2020
Merged

Conversation

paulblum
Copy link
Contributor

@paulblum paulblum commented Dec 8, 2019

Closes issue #17.

This pull request adds the copybutton functionality from Python Docs to all Python Console and Matlab Command Window codeblocks on the Cantera website.

@paulblum paulblum changed the title [WIP [WIP] Add copybutton functionality Dec 8, 2019
Copy link
Member

@bryanwweber bryanwweber left a comment

Just a few comments while you're working on this.

conf.py Outdated Show resolved Hide resolved
plugins/override_html_formatter.py Outdated Show resolved Hide resolved
themes/cantera/assets/js/copybutton.js Show resolved Hide resolved
@paulblum paulblum changed the title [WIP] Add copybutton functionality Add copybutton functionality Dec 13, 2019
@bryanwweber
Copy link
Member

bryanwweber commented Feb 25, 2020

So for the MATLAB sessions, there shouldn't need to be a prompt set on the second line after a continuation. This is a bug in Pygments and I filed pygments/pygments#1399 to address this. I just want to see if I can get a response there before merging this.

@paulblum
Copy link
Contributor Author

paulblum commented Feb 25, 2020

@bryanwweber I noticed that too, added the prompts so that the continuation wouldn't erroneously be displayed as output, as was the case with the bug. Thanks for fixing it!

paulblum and others added 6 commits May 3, 2020
The extra prompt characters were necessary to work around a bug in
Pygments with respect to Matlab line continuation characters. The bug is
fixed in the fork of the Pygments repository that is specified in
requirements.txt. The branch has an open pull request at
pygments/pygments#1399.
bryanwweber added 2 commits May 3, 2020
Pygments is picking up the multiple spaces after the = and doing
something weird with the formatting.
@bryanwweber bryanwweber merged commit 40d7a90 into Cantera:master May 3, 2020
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants