Skip to content

Commit

Permalink
Deprecate class MixedSolventElectrolyte
Browse files Browse the repository at this point in the history
No existing tests, no known example input files, and not constructible via
ThermoFactory.

See #267.
  • Loading branch information
speth committed Feb 23, 2017
1 parent 6154e1b commit 2b73fe2
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions include/cantera/thermo/MixedSolventElectrolyte.h
Expand Up @@ -214,6 +214,7 @@ namespace Cantera
* \f$k^{-1} \f$ has units of s-1.
*
* @ingroup thermoprops
* @deprecated To be removed after Cantera 2.4.
*/
class MixedSolventElectrolyte : public MolarityIonicVPSSTP
{
Expand Down
6 changes: 6 additions & 0 deletions src/thermo/MixedSolventElectrolyte.cpp
Expand Up @@ -20,6 +20,8 @@ MixedSolventElectrolyte::MixedSolventElectrolyte() :
formMargules_(0),
formTempModel_(0)
{
warn_deprecated("class MixedSolventElectrolyte",
"To be removed after Cantera 2.4");
}

MixedSolventElectrolyte::MixedSolventElectrolyte(const std::string& inputFile,
Expand All @@ -28,6 +30,8 @@ MixedSolventElectrolyte::MixedSolventElectrolyte(const std::string& inputFile,
formMargules_(0),
formTempModel_(0)
{
warn_deprecated("class MixedSolventElectrolyte",
"To be removed after Cantera 2.4");
initThermoFile(inputFile, id_);
}

Expand All @@ -37,6 +41,8 @@ MixedSolventElectrolyte::MixedSolventElectrolyte(XML_Node& phaseRoot,
formMargules_(0),
formTempModel_(0)
{
warn_deprecated("class MixedSolventElectrolyte",
"To be removed after Cantera 2.4");
importPhase(phaseRoot, this);
}

Expand Down
1 change: 0 additions & 1 deletion src/thermo/ThermoFactory.cpp
Expand Up @@ -38,7 +38,6 @@
#include "cantera/thermo/DebyeHuckel.h"
#include "cantera/thermo/IdealMolalSoln.h"
#include "cantera/thermo/MolarityIonicVPSSTP.h"
#include "cantera/thermo/MixedSolventElectrolyte.h"
#include "cantera/thermo/IdealSolnGasVPSS.h"
#include "cantera/base/stringUtils.h"

Expand Down

0 comments on commit 2b73fe2

Please sign in to comment.