Ion gas transport fix #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 64.92% 64.92% +<.01%
==========================================
Files 386 386
Lines 40800 40804 +4
==========================================
+ Hits 26489 26493 +4
Misses 14311 14311
Continue to review full report at Codecov.
|
speth
reviewed
Oct 21, 2018
| @@ -858,6 +858,7 @@ cdef extern from "cantera/cython/wrappers.h": | |||
| cdef void tran_getMixDiffCoeffsMole(CxxTransport*, double*) except +translate_exception | |||
| cdef void tran_getThermalDiffCoeffs(CxxTransport*, double*) except +translate_exception | |||
| cdef void tran_getSpeciesViscosities(CxxTransport*, double*) except +translate_exception | |||
| # cdef void tran_getMobilities(CxxTransport*, double*) except +translate_excepttion | |||
There was a problem hiding this comment.
translate_exception is misspelled.
BangShiuh
force-pushed
the
IonGasTransport_fix
branch
from
45bfe87
to
b1e8359
Compare
|
Thank you. It is hard to spot this kind of typo. |
added 3 commits
November 7, 2018 14:43
Also add test_mobility and test_update_temperature to TestIonTransport
speth
force-pushed
the
IonGasTransport_fix
branch
from
b1e8359
to
8138fbe
Compare
|
No problem, and thanks for the updates. I made a few small changes to the tests -- as written, they relied on the tests executing in the order written, which is not guaranteed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for some issues found in IonGasTransport.
Changes proposed in this pull request: