fix(frontend): only send active log sort directions

[riderx]

Summary (AI generated)

• Fix the logs table request payload so only active sort directions are sent to /private/stats
• Apply the same serialization fix to the deployment table, which used the same invalid order shape
• Prevent frontend requests from sending sortable: true, which the backend rejects

Motivation (AI generated)

The device logs page was failing with invalid_body because the frontend serialized all sortable columns into the order array, including unsorted columns represented as true. The backend validates order[*].sortable as only asc or desc, so the request was rejected before any data could load.

Business Impact (AI generated)

This restores the logs experience for users investigating device behavior and update failures. It removes a frontend/backend contract mismatch in an operational debugging flow, reducing support friction and preserving trust in the console for troubleshooting production issues.

Test Plan (AI generated)

• Run bun eslint src/components/tables/LogTable.vue src/components/tables/DeploymentTable.vue
• Open a device logs page and confirm logs load without the invalid_body console error
• Open the deployment table and confirm sorting/filtering requests still succeed

Generated with AI

Summary by CodeRabbit

• Bug Fixes
  • Improved table sorting reliability in Deployment and Log tables by refining how sort directions are handled, ensuring more consistent and predictable ordering of results.

[coderabbitai]

📝 Walkthrough

Walkthrough

Both DeploymentTable.vue and LogTable.vue were updated to restrict the order parameter construction. Previously, any truthy sortable value was included in API requests. Now, only columns with sortable as a string are included, with explicit 'asc' or 'desc' type casting.

Changes

Cohort / File(s)	Summary
Table Order Parameter Refinement src/components/tables/DeploymentTable.vue, src/components/tables/LogTable.vue	Updated order array filtering to require sortable as a string type and cast to explicit 'asc' | 'desc' directions instead of accepting any truthy value. Improves type safety in API payload construction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Whisker-twitched precision found,
Where sorting strings stood proud and sound,
No more truthy shadows stray,
Asc and desc light up the way! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Description check	❓ Inconclusive	The description includes a comprehensive summary, motivation, and business impact. However, the required test plan sections are incomplete: manual testing steps for logs and deployment table are marked incomplete.	Complete the pending test plan items by confirming logs load without errors and deployment table sorting requests still succeed, then update the PR description.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly addresses the main change: filtering sort directions to only send explicit values, fixing the invalid payload issue described in the PR.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-log-order-validation

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

src/components/tables/LogTable.vue (1)

290-292: Consider extracting order serialization into a shared helper.

This logic is duplicated here, in exportCsv(), and in DeploymentTable.vue. A shared helper would reduce drift risk if sorting rules change again.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/components/tables/LogTable.vue` around lines 290 - 292, Extract the logic
that builds the serialized sort order (currently implemented as
columns.value.filter(elem => typeof elem.sortable === 'string').map(elem => ({
key: elem.key as string, sortable: elem.sortable as 'asc' | 'desc' })) ) into a
single shared helper (e.g., serializeColumnOrder(columns):
Array<{key:string,sortable:'asc'|'desc'}>), export it from a common utilities
module, and replace the in-place code in LogTable.vue, exportCsv(), and
DeploymentTable.vue to call that helper so all three use the same implementation
and avoid duplication.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/components/tables/LogTable.vue`:
- Around line 290-292: Extract the logic that builds the serialized sort order
(currently implemented as columns.value.filter(elem => typeof elem.sortable ===
'string').map(elem => ({ key: elem.key as string, sortable: elem.sortable as
'asc' | 'desc' })) ) into a single shared helper (e.g.,
serializeColumnOrder(columns): Array<{key:string,sortable:'asc'|'desc'}>),
export it from a common utilities module, and replace the in-place code in
LogTable.vue, exportCsv(), and DeploymentTable.vue to call that helper so all
three use the same implementation and avoid duplication.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2213628c-9403-4de9-94dc-d66526aeb6df

📥 Commits

Reviewing files that changed from the base of the PR and between a521f9f and ef74073.

📒 Files selected for processing (2)

• src/components/tables/DeploymentTable.vue
• src/components/tables/LogTable.vue

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
100.0% Duplication on New Code

See analysis details on SonarQube Cloud