osce-pair-programming

Spring Boot application that retrieves a price (which is a rate multiplied by a fixed commission percentage) for a date.

Endpoints available are:

• GET /price retrieve price for current date
• GET /price/{date} retrieve price for a given date (format yyyy-mm-dd)

You have been employed by the client to alter some business logic and to advise on any improvements that could be made to the code.

Note; the commission percentage (9%) has never changed since the application was introduced.

Requirement 1

The client has asked for the following rate change to be made to the service:

• From date: 2020-07-01
• To date: 2099-12-31
• Rate: 0.87

The commission percentage is to remain at 9%.

They've asked that appropriate tests are added to ensure the new rate entries are correct.

Requirement 2

testFindPriceMethod contains a TODO comment for a test assertion that has never passed. Uncomment the assertion to see if you can find out why.

Requirement 3

There have been complaints that the service occasionally fails, usually (but not always) at the end of a month. The last report of a failure was on the 31st July 2020. The client has asked you to see if you can replicate the issue and provide a fix.

Requirement 4

The client has asked you to provide feedback on the maintainability of the current code as they may be able to secure funding for any refactoring that might be beneficial.

They're particularly keen to know about:

• the quality of the code; the company is disputing the cost of the initial service development and would like to know what code quality issues they can use to aid their case.
• how they could make simple changes to the service in future without development costs