Image overlay bugs #246
Merged
Image overlay bugs #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvidentlyCube
force-pushed
the
image-overlay-bugs
branch
from
88b2233
to
0eed1fe
Compare
|
@EvidentlyCube , the other PRs are merged. This PR can now be rebased. |
…t duplicate the effect for one turn
… it's closed. Everything also works correctly with losing and regaining focus. Finally, dialogs will delegate handling windows focus back to their parent (who should either be a screen or another dialog, which in turn will delegate it all the way back to a screen). This allows having special handling for focus, eg. repausing sound if dialog is open
EvidentlyCube
force-pushed
the
image-overlay-bugs
branch
from
0eed1fe
to
b6be6ad
Compare
|
@mrimer Ready to review and merge |
mrimer
approved these changes
Oct 29, 2020
| { | ||
| g_pTheSound->PauseSounds(); | ||
|
|
||
| const Uint32 dwSpeechRemaining = this->dwNextSpeech - SDL_GetTicks(); |
There was a problem hiding this comment.
I note here that if dwNextSpeech == 0, then this unsigned value will translate the negative ts to a large positive.
That seems benign, though, as the value won't be used in this case.
|
@EvidentlyCube , Really elegant improvements built on your nice effect refactoring. I like the vision you put forth and executed on! |
mrimer
added a commit
to mrimer/drod
that referenced
this pull request
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as draft since it depends on changes from #228 and #245.
Relevant thread