Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account #53

wants to merge 6 commits into from
Closed #53

wants to merge 6 commits into from


Copy link

A4 Initial Commit Submission.

Copy link

Hi all - some brief comments on my A4 submission (specifically, on what I've implemented for the A4 requirements) before our code review.

  1. I've added a CareKit implementation to track adherence for three tasks (two professional development exercises, one survey task). The survey task, though, feels disjointed - I have a checklist (to help users track when in the day they should be filling out the survey), and a survey task (to provide easy access to start the survey), and it seems as though there should be an easy way to blend the two of these interfaces into one unified view. I'm hoping we can discuss this more during our code review.
  2. I've added two CareKit charts: one for tracking survey completion, the other for tracking step count throughout the day. (Though the step count one has pretty limited testing, as everything has been done in simulator so far).
  3. My new Firestore rules are as follows (and they have been added/deployed to the Firestore backend):
rules_version = '2';
service cloud.firestore {
  match /databases/{database}/documents {
    // Make sure the uid of the requesting user matches name of the user
    // document. The wildcard expression {userId} makes the userId variable
    // available in rules.
    match /users/{userId} {
      allow read, update, delete: if request.auth != null && request.auth.uid == userId;
      allow create: if request.auth != null;
  1. EHRs are not a required feature of this application - I would like to verify with you that this is not a required portion of my A4 submission.
  2. I've updated the "Your Team" screen to include contact card information for member of the research team, replacing the design I had previously used which was my A1 submission.

@vishnuravi vishnuravi closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants