Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

YouTube percentages not used #24

Closed
dbarlett opened this Issue May 11, 2012 · 8 comments

Comments

Projects
None yet
3 participants
Contributor

dbarlett commented May 11, 2012

I followed the example in the readme to add percentages: [25, 50, 75, 90] to the _gasTrackYoutube call, but did not see any percentage events in GA. Stepping thru in Firebug showed that lines 209-215 of youtube.js result in opts = {} and thus opts['percentages'] = [].

Contributor

eduardocereto commented May 11, 2012

I can't reproduce this. It works for me. I'll close this because it doesn't have enough information. opts is not overwritten if you send a parameter to _gasTrackYoutube. You can either reopen it with an example of a page that is broken or a pull request of the supposed fix.

You should not see youtube.js on Firebug. You should use one of the compiled files from the Download page:

https://github.com/CardinalPath/gas/downloads

Contributor

dbarlett commented May 11, 2012

Can you provide a working example page so I can determine if my browsers are at fault?

Example page: http://dylanbarlett.com/gastest.html

Steps to reproduce:

  1. Copy unminified gas.js to server.
  2. Supply percentages in call to _gasTrackYoutube per readme.
  3. Start and pause video.
  4. Observe that GET requests are made to __utm.gif with play and pause events, as expected. Confirm that events are shown in Google Analytics.
  5. Observe no GET requests are made with percentage events, and no events are shown in GA.

Debugging:

  1. Set breakpoint on line 1534 of gas.js
  2. Watch value of opts = Object { force=false, category="YouTube Video", percentages=[0]}

@eduardocereto eduardocereto reopened this May 11, 2012

Contributor

eduardocereto commented May 11, 2012

You're right. Thanks for pointing it out. I think I need some sleep.

Contributor

eduardocereto commented May 11, 2012

I just uploaded v1.8 with this fix. Let m know if that works for you.

https://github.com/CardinalPath/gas/downloads

Contributor

dbarlett commented May 11, 2012

Thanks for the fix. gas.js downloads fine, but gas.min.js results in File was not found.

Contributor

eduardocereto commented May 14, 2012

@dbarlett fixed

dijust commented Mar 19, 2013

Hi,

This is still a problem for me. Was this fix ever confirmed?

Thx
Justin

Contributor

dbarlett commented Mar 19, 2013

Works for me, calling v1.10.1 from cdnjs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment