Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Full base Implementation of node-disks #2
See also Carimus/node-uploads#2.
This PR is a merge of master (what's released onto npm right now) into a temporary branch upstream-base which represents essentially the starting point for this PR.
As such, this PR contains the entire functional implementation of node-uploads up to this point (v1.11.0).
referenced this pull request
Apr 12, 2019
KristenKatona left a comment
Just saw a couple TODOs that might need tasks generated if they're still needing to be completed. Too much to look through line by line but scanned through and saw some unit tests and I assume those are passing and provide sufficient coverage (and that we'll test this in our project).
Hey @KristenKatona !
Yep! You can't actually see in the "All checks have passed section" that every push to this repo runs the tests and will reject if the tests fail. I didn't do a code coverage report but I'd say a good 50% of the code is covered by tests (the remaining untested code is mostly on the s3 side since it's hard to write unit tests against external resources).
I have the meaningful/important TODOs captured in the README which will have to do for now since we don't have a JIRA project to track carimus general / open source stuff.