Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base implementation #1

merged 27 commits into from Apr 12, 2019


None yet
2 participants
Copy link

bericp1 commented Apr 5, 2019


bericp1 added some commits Apr 4, 2019

feat(*): implement the base logic for uploading files and handling disks
Still need to implement delete and transfer and write some tests for the repository functionality
before this is ready to ship.

@bericp1 bericp1 added the WIP label Apr 5, 2019

bericp1 added some commits Apr 5, 2019

revert(ci): undo prepack for git install
Due to yarnpkg/yarn#5047, prepack doesnt get triggered with yarn so we cant do direct git installs
in a consistent way unfortunately.
fix(*): write tests for service and fix revealed bugs

-   Add `MemoryRepository` (basically an in-memory db) to support tests
-   Test the entire Uploads public API surface area
-   Fix revealed bugs from tests
-   Actually delete on update (to mimc file move)
-   Install memfs in order to use a memory disk for testing
-   Use process.hrtime for generation of filenames to get unique timestamps even in the same tick
docs(*): detailed usage docs
Also, reorganize the transfer arguments to make more sense

@bericp1 bericp1 force-pushed the feature/initial-implementation branch from 1f50485 to a824d88 Apr 12, 2019

@bericp1 bericp1 removed the WIP label Apr 12, 2019

@bericp1 bericp1 merged commit 4d351f4 into master Apr 12, 2019


This comment has been minimized.

Copy link

carimus-deploy-bot commented Apr 12, 2019

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bericp1 bericp1 deleted the feature/initial-implementation branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.