Skip to content

Commit

Permalink
Revert "Merge pull request #2496 from Mov1s/issue/2493-url-characters…
Browse files Browse the repository at this point in the history
…-in-derived-data-path"

This reverts commit e0d2498, reversing
changes made to 5b8965e.
  • Loading branch information
tmspzz committed Jul 2, 2018
1 parent 9b2aabf commit 7b8bc2f
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
3 changes: 1 addition & 2 deletions Source/CarthageKit/GitURL.swift
Expand Up @@ -52,8 +52,7 @@ public struct GitURL {
return components
.last
.map(String.init)
.map(strippingGitSuffix)?
.removingPercentEncoding
.map(strippingGitSuffix)
}

public init(_ urlString: String) {
Expand Down
6 changes: 0 additions & 6 deletions Tests/CarthageKitTests/DependencySpec.swift
Expand Up @@ -78,12 +78,6 @@ class DependencySpec: QuickSpec {

expect(dependency.name) == "myproject"
}

it("should have percent encoding removed") {
let dependency = Dependency.git(GitURL("ssh://server.com/my%20project%20with%20spaces.git"))

expect(dependency.name) == "my project with spaces"
}

it("should be the entire URL string if there is no last component") {
let dependency = Dependency.git(GitURL("whatisthisurleven"))
Expand Down

0 comments on commit 7b8bc2f

Please sign in to comment.