New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix picking up submodules in locateProjectsInDirectory() #1035

Merged
merged 1 commit into from Jan 15, 2016

Conversation

Projects
None yet
3 participants
@ikesyo
Member

ikesyo commented Jan 11, 2016

Correctly ignore submodules inside --no-use-submodules checkouts.

Should/might fix #1029.

Fix picking up submodules in locateProjectsInDirectory()
Correctly ignore submodules inside `--no-use-submodules` checkouts.
@ikesyo

This comment has been minimized.

Show comment
Hide comment
@ikesyo
Member

ikesyo commented Jan 11, 2016

/cc @kballard

@kballard

This comment has been minimized.

Show comment
Hide comment
@kballard

kballard Jan 11, 2016

Contributor

Just tested your branch against my project and it seems to run correctly.

Contributor

kballard commented Jan 11, 2016

Just tested your branch against my project and it seems to run correctly.

@mdiep

This comment has been minimized.

Show comment
Hide comment
@mdiep

mdiep Jan 15, 2016

Member

Great job. 👏

Member

mdiep commented Jan 15, 2016

Great job. 👏

mdiep added a commit that referenced this pull request Jan 15, 2016

Merge pull request #1035 from Carthage/fix-picking-up-submodules
Fix picking up submodules in locateProjectsInDirectory()

@mdiep mdiep merged commit f0d1a2a into master Jan 15, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mdiep mdiep deleted the fix-picking-up-submodules branch Jan 15, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment