Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle frameworks with no debug symbols #1932

Merged
merged 2 commits into from
May 15, 2017

Conversation

erichoracek
Copy link
Member

This is a prerequisite to static framework support. See #1379.

This is a prerequisite to static framework support. See Carthage#1379.
Copy link
Member

@mdiep mdiep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one request.


return createDebugInformation(builtProductURL)
.then(SignalProducer<URL, CarthageError>(value: builtProductURL))
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind altering this slightly to move the .then outside?

			return UUIDsForFramework(builtProductURL)
				.collect()
				.flatMap(.concat) { uuids -> SignalProducer<URL, CarthageError> in
					// Only attempt to create debug info if there is at least 
					// one dSYM architecture UUID in the framework. This can 
					// occur if the framework is a static framework packaged 
					// like a dynamic framework.
					if uuids.isEmpty {
						return .empty
					}

					return createDebugInformation(builtProductURL)
				}
				.then(SignalProducer<URL, CarthageError>(value: builtProductURL))

(The return type in that flatMap is most likely not right now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants