Implement batch logger to log query times #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgaubert
commented
Sep 29, 2016
batch/batch-logger.js
Outdated
| continue; | ||
| } | ||
|
|
||
| var node = parseQueryId(query.id); |
Contributor
Author
There was a problem hiding this comment.
@rochoa, do you think It's a good idea to parse here the id? Or should it be done in beaver/logstash?
The idea is to implement logger agnostic as much as possible.
- Add query id if exists - Only log analyses for expected format - Log with query start and end times
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement batch logger to log query times when queries are defined with id