Make a single sql-api request for both affected-tables and last-modified #145

Closed
strk opened this Issue Feb 17, 2014 · 4 comments

Comments

Projects
None yet
2 participants
Contributor

strk commented Feb 17, 2014

Connecting to the sql-api is an expensive operation, doing it twice for every mapconfig creation is a bottleneck.

strk added the enhancement label Feb 17, 2014

strk added the performance label Feb 25, 2014

Contributor

strk commented Feb 25, 2014

The reason why this was done as two distinct queries was because the "affectedTables" one was likely to be cached in Varnish (if in use), but given that the configuration might choose a direct connection instead... it isn't a good optimization.

strk added this to the 1.8.3 milestone Feb 25, 2014

Contributor

strk commented Feb 26, 2014

I've just found out that a call to "lastUpdated" is made even when the list of affected tables is empty. That's just lame :)

@strk strk modified the milestone: 1.8.4, 1.8.3 Feb 27, 2014

Contributor

strk commented Feb 27, 2014

With f24e4f8 there is no "lastUpdated" call if query is affected by no tables.

@strk strk modified the milestone: 1.8.5, 1.8.4, 1.8.6 Mar 3, 2014

strk removed this from the 1.8.6 milestone Mar 12, 2014

Owner

rochoa commented Jan 28, 2015

This was implemented in 3af45e1

rochoa closed this Jan 28, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment