Skip to content

Do not query table metadata with an empty list of tables #168

Closed
strk opened this Issue Feb 26, 2014 · 1 comment

1 participant

@strk
strk commented Feb 26, 2014

The findLastUpdated function is sending a query to sql-api even if the list of tables is empty. It's a low hanging fruit..

Probably uncommon, but I use those kind of queries a lot for testing.
See #145 for the longer-time fix.

@strk strk added this to the 1.8.3 milestone Feb 26, 2014
@strk strk self-assigned this Feb 26, 2014
@strk strk added a commit that closed this issue Feb 27, 2014
@strk strk Oops, previous commit closed #168, not #16
Closes #168
625642c
@strk strk closed this in 625642c Feb 27, 2014
@strk
strk commented Feb 27, 2014

The change didn't really work, due to affectedTables returning a single-element rather than zero-element array for queries being affected by no tables.

This, in turn, is due to ''.split(',').length being 1,
well, matter for another ticket :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.