Skip to content

Reduce number of calls to req2params on map creation #157

Closed
strk opened this Issue Feb 25, 2014 · 1 comment

1 participant

@strk
strk commented Feb 25, 2014

I noticed that req2param is invoked by getTileOrGrid, which is invoked not only per-request but also internally as part of checking a newly created layergroup.

For a layergroup with multiple layers this would mean multiple calls to the same function for a single request. It has to be closely inspected, and ideally we'd have a test counting the number of calls.

@strk strk added the enhancement label Feb 25, 2014
@strk
strk commented Feb 25, 2014

I confirm a POST to /layergroup with a MapConfig made of 2 layers results in a total of 4 calls to req2params.

@strk strk added this to the 0.19.1 milestone Feb 26, 2014
@strk strk added the performance label Feb 26, 2014
@strk strk added a commit that closed this issue Feb 26, 2014
@strk strk Do not call req2params again while testing created layergroups
Includes testcase.
Closes #157
b1cb733
@strk strk closed this in b1cb733 Feb 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.