Test MapConfig objects against each database ? #163

Closed
strk opened this Issue Feb 26, 2014 · 3 comments

1 participant

@strk

As of today the MapConfig objects are only checked on "first seen".
Given that the same MapConfig could be used against possibly different databases, it may be better to check them on "first seen used" instead.

That is, check them once for each target database, rather than once for all.

Note that database structure could change, so the test could eventually become old even if more specific, unless a mechanism is setup to invalidate these caches.

@strk

See #160 and #162 for a recent activity around this spot

@strk

Note that including the database name into the MapConfig object would generate a different hash for different targets, making this happen automatically...

@strk

I've a working patch for this. Of course it changes the tokens of all (temporary) maps.
Not a big deal because maps are read-only anyway and they expire when unused anyway...

@strk strk added a commit that closed this issue Feb 28, 2014
@strk strk Inject db parameters in user-provided MapConfig objects
Doing so avoids the wrong assumption that the _same_ MapConfig
would work the same against every database and for every user.

Closes #163.
8c6b7d0
@strk strk closed this in 8c6b7d0 Feb 28, 2014
@strk strk added this to the 1.19.2 milestone Feb 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment