Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intersection analysis is missleading #10263

Closed
javisantana opened this issue Oct 19, 2016 · 5 comments
Closed

intersection analysis is missleading #10263

javisantana opened this issue Oct 19, 2016 · 5 comments
Labels

Comments

@javisantana
Copy link
Contributor

We have a intersection analysis that works with any geometry but no all the intersecions make sense:

  • polygon - point <- perfect sense and the typical use case
  • point - polygon <- what is the use case?
  • line - point <- this does not work because the change a line a point intersects is really low
  • line - line <- what is the use case?
  • polygon - polygon <- what is the use case?
  • point - point <- wont work

So my proposal is to simplify and have a polygon - point and then some specific like "aggregate by line" where we find closest point.

cc @saleiva

@saleiva
Copy link
Contributor

saleiva commented Oct 19, 2016

+1

@saleiva saleiva added this to the Builder milestone Oct 19, 2016
@zingbot
Copy link

zingbot commented Oct 20, 2016

Having done work with tons of students on this, here's the answer to a few:

point - polygon <- what is the use case?

  • same as polygon-point

line - point <- this does not work because the change a line a point intersects is really low

  • I can't think of one

line - line <- what is the use case?

  • Actual intersections, like streets, or ship paths, trying to find the points where lines cross. Very useful in transportation work.

polygon - polygon <- what is the use case?

  • Sales territories and metropolitan regions, or watersheds and states, or zip codes and census blocks

You are missing:
line- polygon
*find all roads in this provice, give me the routes paths of all runners in this park

@talos
Copy link
Contributor

talos commented Oct 20, 2016

If you consider "intersection" more broadly as a spatial join, where the two geometries do not necessarily exist in the same space but have a relationship that the user might be concerned about, I've listed the use cases below. However, they might not really fit under the name "intersection" and should live in a different analysis:

  • point - polygon <- This is the inverse of polygon-point, is the expectation that these are not symmetrical?
  • line - point <- Finding the closest PoIs to a road. This probably dissolves to a line->buffer->point in polygon equation
  • line - line <- Finding intersections (points where the lines cross)
  • polygon - polygon <- Boolean operations. For example, subtracting one shape from another
  • point - point <- Closest N points to another point. For example, I am thinking of building a fruit stand and I want to know the 3 nearest fruit stands. This doesn't dissolve to a buffer issue, it's nearest neighbors.
  • polygon - line (not mentioned above) <- splitting a polygon into N other polygons based off of lines.

@talos
Copy link
Contributor

talos commented Oct 20, 2016

Also, I'd say that I don't think any of the additional cases I outlined above are at all high priority, just that they do exist. And to reiterate, "intersection" is not the right term for many of them.

The only one I think that could be useful sooner rather than later would be point - point, just plugging into KNN. And also to make sure that point-polygon and polygon-point are interchangeable, if possible.

@xavijam xavijam removed this from the Builder milestone Dec 2, 2016
@stale
Copy link

stale bot commented Feb 20, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Feb 20, 2018
@stale stale bot closed this as completed Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants