[ch98965] Error importing geopackage files with multiple layers

[Shylpx]

Resources

• Clubhouse story

Context

• When a geopackage file has multiple layers, in order to create a dataset for each layer (max 50), the CartoDB::Importer2::GpkgSplitter checks the number of layers. To get this, it uses the ogrinfo command that gives information about the layers (name, type), and it is parsed using regular expressions to extract the name of each layer.
• The error was in that regular expressions, because the information of each layer is something like 1: layer_name (Line String), and the splitter removes the number before the layer name and the geometry between parenthesis before the name. But for a specific type of layer geometry, it fails: 2: layer_name (3D Measured Unknown (any)). Because the regular expression was not considering that the string between parenthesis could have also parenthesis to be removed.
• The result is a geopackage with 16 layers with that geometry, and the splitter understand that there are 0 layers, so the result is trying to import all the layers with the same name and of course it fails because the layer already exists when tries to import the second one.

Changes

• Fix regular expression to extract the layer name correctly.
• Update test to consider the corner case.
• Minor Rubocop fixes.

[rafatower]

👍 thanks for the fix.

I re-triggered the builds cancelled:

HEAD is now at 30fce9d Merge branch 'master' into feature/ch98965/initiative-error-uploading-a-geopackage-file
ERROR
ERROR: error fetching git source: context canceled

because we should make sure there's no regression test broken (unlikely, but better safe - e.g: there is another gpkg file with tests associated to it). Please, don't cancel CI builds unless there's a good reason to do so 😉

Thanks! :)