Lines support #19

Merged
merged 13 commits into from Jan 17, 2017

Projects

None yet

3 participants

@donflopez
Collaborator
donflopez commented Jan 4, 2017 edited

PR finished

Fix #18

donflopez added some commits Jan 4, 2017
@donflopez donflopez Join & cap working
e735ff9
@donflopez donflopez Add comp-op to lines
cb25071
@donflopez donflopez changed the title from Join & cap working to Lines support Jan 4, 2017
donflopez added some commits Jan 4, 2017
@donflopez donflopez Add line-dasharray feature
58a7859
@donflopez donflopez Add some improvements and documentation
4ba9fd9
@donflopez donflopez Remove unused dep
b1d418d
@donflopez donflopez Add comp-op to polygons e4520d0
@donflopez donflopez Add check to draw fn 361f56c
@donflopez donflopez Add texture and sym checks bc5ca40
@donflopez donflopez Add pattern-polygon-file feature 1f3646d
@donflopez donflopez Fix tests
02befc6
@donflopez donflopez Change naming by hash and fix tests
bff7e39
@donflopez donflopez Bump tangran-reference
c6827c3
@donflopez donflopez requested a review from javisantana Jan 9, 2017
src/basic/reference-helpers.js
+ */
+var ReferenceHelper = {};
+
+let RH = ReferenceHelper;
@javisantana
javisantana Jan 12, 2017 Member

I personally don't like names like this. ReferenceHelper is longer but it's clear what you are using all over the code

@donflopez
donflopez Jan 12, 2017 Collaborator

You're right! I've removed it completely :)

@donflopez donflopez Remove bad RH object name
6d215d5
@rochoa
Member
rochoa commented Jan 17, 2017

I would remove dist/* files.

@rochoa rochoa merged commit 0cec33e into master Jan 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@rochoa rochoa deleted the line-support branch Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment