Skip to content
This repository has been archived by the owner on Sep 24, 2022. It is now read-only.

Show off highest official role #124

Merged
merged 11 commits into from
Jun 16, 2019
Merged

Show off highest official role #124

merged 11 commits into from
Jun 16, 2019

Conversation

DeadlyFirex
Copy link
Contributor

Pull request

  • I have read and agreed to the code of conduct.
  • I have read and complied with the contributing guidelines.
  • What I'm implementing was assigned to me or was not being worked on and is a somewhat requested feature. For reference see our GitHub projects.
  • I have tested all of my changes.

Added/Changed

What did you add and/or change for this.

  • Added a check that shows off official roles applicable to an user

Feature

If this is a new feature, why should we add it to the bot.

  • Merely an addition, adds checks if user x. has a special role Owner, Developer etc.

@binaryoverload
Copy link
Member

Use EnumUtils.formatEnum(), converts the first letter to a capital and the rest to lower case

@DeadlyFirex
Copy link
Contributor Author

Actually StringUtils.capitalize() does the same @binaryoverload

@binaryoverload
Copy link
Member

I'm aware, use enum utils please as it will make it easier for me to find and languagify it later on.

@DeadlyFirex
Copy link
Contributor Author

Should work now ^

@DeadlyFirex DeadlyFirex changed the title Show off Official Roles Show off highest official role Jun 15, 2019
@DeadlyFirex DeadlyFirex changed the title Show off highest official role Show off highest official role Jun 15, 2019
JamesHawkinss
JamesHawkinss previously approved these changes Jun 15, 2019
Copy link
Contributor

@JamesHawkinss JamesHawkinss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good 😃

@DeadlyFirex
Copy link
Contributor Author

It should be there right now @binaryoverload

binaryoverload
binaryoverload previously approved these changes Jun 15, 2019
Copy link
Member

@binaryoverload binaryoverload left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

weeryan17
weeryan17 previously approved these changes Jun 15, 2019
@weeryan17
Copy link
Member

@DeadlyFirex just cause someone else found a small issue, and subsequently made a small change doesn't make old reviews invalid, and only slows down the merging of prs.

@weeryan17
Copy link
Member

@DeadlyFirex just cause someone else found a small issue, and subsequently made a small change doesn't make old reviews invalid, and only slows down the merging of prs.

Nvm apparently it was github auto doing it

Copy link
Member

@weeryan17 weeryan17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge the dev branch. if you run into issues ask me or binary to help. after that we can get this pr mrged

@binaryoverload binaryoverload merged commit 0dbfa68 into CascadeBot:dev Jun 16, 2019
@DeadlyFirex DeadlyFirex deleted the patch-2 branch June 16, 2019 17:18
@binaryoverload binaryoverload added this to the Alpha milestone Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants