Return highlighted excerpt of result (again) #280
Conversation
|
Ping! BTW: I don't know what I should do with rubocop and the errors in travis, on my machine works fine. |
|
The RuboCop failure was an issue on master which I’ve just fixed. If you rebase your changes and re-push your build should pass. |
ceritium
force-pushed
the
highlight
branch
2 times, most recently
from
cbf1d8b
to
699a20e
Compare
|
Thanks @amarshall |
|
By the way I don't want to come across as harsh. I really appreciate the work you've put into this pull request. I think we can work through some small details and then get this in for sure. |
Basically I adapted Casecommons#211
| "StartSel" => options[:highlight][:start_sel], | ||
| "StopSel" => options[:highlight][:stop_sel], | ||
| "MaxFragments" => options[:highlight][:max_fragments] | ||
| } |
There was a problem hiding this comment.
What do you think of allowing other options?
From the docs:
- FragmentDelimiter
- HighlightAll
- ShortWord
- MaxWords, MinWords
There was a problem hiding this comment.
It is good idea, also I think that the options could be passed in the query and overwrite the default configuration.
|
I haven't been active on this repo recently, but just chiming in to say that this looks solid, and it would be something that I'd use personally at @dobtco. |
Return highlighted excerpt of result (again)
|
👍 nice. Thanks. |
Basically I adapted #211