Rework P2PKH template building #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ekey with signature and public key
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…(currently fails)
Member
|
Hey @mainnet-pat, thanks for picking this up! We commented some of our findings in #323 and opened a new issue #359 to improve debuggability of P2PKH inputs in the future. There's still one fixture that is unupdated for the changes. If you want to pick that up, feel free, if not, we will make that edit later this week and merge the PR. |
rkalis
added a commit
that referenced
this pull request
Oct 2, 2025
Co-authored-by: Rosco Kalis <roscokalis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #323