Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved flex utility classes (to be used in wider context) #39

Merged
merged 2 commits into from Feb 20, 2018

Conversation

Paulus90
Copy link

Moved flexbox utility classes from grid partial to utility partial and removed the grid dependency, so these classes can be used in a wider context.

…al and removed the grid dependency, so these classes can be used in a wider contect.
@Paulus90
Copy link
Author

Paulus90 commented Oct 3, 2017

@dariusrosendahl wil jij deze reviewen?

@Paulus90 Paulus90 requested review from gbeumer and dariusrosendahl and removed request for dariusrosendahl October 3, 2017 12:35
@pascalalferink
Copy link

pascalalferink commented Feb 14, 2018

It agree it is a valid improvement.
I have one concern: most of the css-classes that are moved have an abbreviation before the hyphen, that correlates to the property that is styled. For instance all the classes starting with "jc-" are about the property justify-content.

The classes .wrap and .nowrap don't have these abbreviations with hyphen. This makes the classname somewhat ambiguous, because it can also be interpreted as a css-classes that modifies the property white-space or word-break.

It think it would be an additional improvement to prefix these classes to .fw-wrap and .fw-nowrap, and keep the original classes in the grid for backwards compatibility

@dariusrosendahl
Copy link
Member

It think it would be an additional improvement to prefix these classes to .fw-wrap and .fw-nowrap, and keep the original classes in the grid for backwards compatibility

@pascalalferink : Agreed, could you add this to the pullrequest?

@pascalalferink
Copy link

pascalalferink commented Feb 14, 2018

classnames are modified as requested

after merging this feature, don't forget to change caslecss-docs

@dariusrosendahl dariusrosendahl merged commit 918f625 into develop Feb 20, 2018
@dariusrosendahl dariusrosendahl deleted the feature/Flex_utility_classes branch February 20, 2018 08:42
@dariusrosendahl dariusrosendahl mentioned this pull request Feb 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants