Added :not(.input-control) selector to label[for] selectors. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paulus90
commented
Mar 19, 2018
Paulus90
commented
- Added :not(.input-control) selector to label[for] selectors. The stylerules in place only apply to 'placeholder' labels in input fields (not radio/checkbox labels). It broke radiobuttons/checkboxes when their labels contained a [for] attribute
- Bear in mind: this fix should be temporary due to an upcoming fix in forms version 2.0 (issue Feature/default label not working in version 1.0.7 #14)
…ylerules in place only apply to 'placeholder' labels in input fields (not radio/checkbox labels). It broke radiobuttons/checkboxes when their labels contained a [for] attribute - Bear in mind: this fix should be temporary due to an upcoming fix in forms version 2.0 (issue #14)
dariusrosendahl
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.