Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup docker setup #14

Merged
merged 6 commits into from Aug 6, 2018
Merged

Cleanup docker setup #14

merged 6 commits into from Aug 6, 2018

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Aug 6, 2018

This pull request implements assorted cleanups for the docker setup:

  • Avoid relying on volume for nginx configuration
  • Avoid relying on latest docker tag and fix MySQL version to one support on hosted Azure
  • Move docker commands to one per line
  • Avoid storing pip cache in docker image
  • Make app bind port configurable
  • Fix test docker-compose setup

See #9

@c-w c-w requested a review from michaelperel Aug 6, 2018
@c-w c-w merged commit 7c88952 into master Aug 6, 2018
@c-w c-w deleted the cleanup-docker branch Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants