Skip to content

Cleanup docker setup - #14

Merged
c-w merged 6 commits into
masterfrom
cleanup-docker
Aug 6, 2018
Merged

Cleanup docker setup#14
c-w merged 6 commits into
masterfrom
cleanup-docker

Conversation

@c-w

@c-w c-w commented Aug 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request implements assorted cleanups for the docker setup:

  • Avoid relying on volume for nginx configuration
  • Avoid relying on latest docker tag and fix MySQL version to one support on hosted Azure
  • Move docker commands to one per line
  • Avoid storing pip cache in docker image
  • Make app bind port configurable
  • Fix test docker-compose setup

See #9

@c-w
c-w requested a review from michaelperel August 6, 2018 14:09
@c-w
c-w merged commit 7c88952 into master Aug 6, 2018
@c-w
c-w deleted the cleanup-docker branch August 6, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@michaelperel michaelperel michaelperel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c-w @michaelperel