Cleanup docker setup #14

c-w · 2018-08-06T14:09:07Z

This pull request implements assorted cleanups for the docker setup:

Avoid relying on volume for nginx configuration
Avoid relying on latest docker tag and fix MySQL version to one support on hosted Azure
Move docker commands to one per line
Avoid storing pip cache in docker image
Make app bind port configurable
Fix test docker-compose setup

See #9

- Avoid manual management directories for test volumes - Fix mysql crash due to non-empty volume mount on docker-for-windows - Remove duplicate docker-compose file

c-w added 6 commits August 6, 2018 08:59

Avoid relying on volume for configuration

584a9c7

Fix MySQL version to one support on hosted Azure

d9a2e9d

Move docker commands to one per line

8e10868

Avoid storing pip cache in docker image

38ad365

Make app bind port configurable

c2db43b

Fix test docker-compose setup

6f2cb62

- Avoid manual management directories for test volumes - Fix mysql crash due to non-empty volume mount on docker-for-windows - Remove duplicate docker-compose file

c-w requested a review from michaelperel August 6, 2018 14:09

michaelperel approved these changes Aug 6, 2018

View reviewed changes

c-w merged commit 7c88952 into master Aug 6, 2018

c-w deleted the cleanup-docker branch August 6, 2018 14:37

Cleanup docker setup #14

Cleanup docker setup #14

Conversation

c-w commented Aug 6, 2018 • edited

c-w commented Aug 6, 2018 •

edited