Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define API layer #25

Merged
merged 6 commits into from Aug 8, 2018

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Aug 8, 2018

This pull request defines a boundary between business/domain logic (how do we go about storing and analyzing images) and the API layer (Flask specifics such as which REST and Auth frameworks are used).

This increases testability and makes it easier to understand the code since each layer has well defined responsibilities:

  • Models are for data storage.
  • The auth layer verifies access to the application independent of the web framework that is used.
  • The domain layer implements the app's functionality.
  • The API layer adapts between HTTP requests and business logic or authentication.

@c-w c-w requested a review from michaelperel Aug 8, 2018

@c-w c-w merged commit 03b634b into master Aug 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the api-layer branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.