Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FaceAPI algorithm container #37

Merged
merged 5 commits into from Aug 13, 2018

Conversation

Projects
None yet
4 participants
@c-w
Copy link
Member

commented Aug 13, 2018

See #6

@c-w c-w requested a review from armanrahman22 Aug 13, 2018

public async Task<bool> Evaluate(string groupId, double matchThreshold, string imagePath1, string imagePath2)
{
var faces = await Task.WhenAll(new[] { DetectFaces(imagePath1), DetectFaces(imagePath2) });
var result = await Client.Face.VerifyFaceToFaceAsync(faces[0][0], faces[1][0]);

This comment has been minimized.

Copy link
@armanrahman22

armanrahman22 Aug 13, 2018

Collaborator

Would it be possible to change this so that it checks all faces in both images and if any pair is a match returns true? That way for testing we can use images that have multiple people in them.

This comment has been minimized.

Copy link
@c-w

c-w Aug 13, 2018

Author Member

I thought this would be handled during the alignment step prior to running the evaluation? I just pushed an evaluation function that computes accuracy/precision/recall given a pairs.txt file. Check it out: 7d5d577.

This comment has been minimized.

Copy link
@c-w

c-w Aug 13, 2018

Author Member

This might still be useful though for the custom data-set (where we don't necessarily know exactly who are all the people in the image), so I've submitted an issue for this #38.

@c-w c-w force-pushed the face-api branch from 7d5d577 to cf02c92 Aug 13, 2018

@c-w c-w force-pushed the face-api branch from 4beece2 to 4b6a114 Aug 13, 2018

@Foxman13
Copy link
Collaborator

left a comment

Usually, when building a CLI, there is parsing for the args that has error handling built in for missing or wrong arguments. I can see in this implementation where if no args or the wrong args are passed in, the application would crash due to NullReferenceException.

Should we add this type of pattern or are we even using the CLI?

@michaelperel michaelperel merged commit ef7c84f into master Aug 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the face-api branch Aug 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.