Add lint for scripts and fix all issues #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelperel
approved these changes
Aug 20, 2018
Makefile
Outdated
|
|
||
| .PHONY: flake8-scripts | ||
| flake8-scripts: build-scripts | ||
| docker run --entrypoint=sh "$(get_famous_people_list)" -c "pip -qqq install flake8 && flake8 *.py" |
There was a problem hiding this comment.
With -qqq, is it advisable to silence critical level logging warnings?
There was a problem hiding this comment.
That should be fine. pip install is not expected to fail and if it does, the entire command will fail (due to the &&) so we know what to look into. Having low verbosity definitely is nicer in the CI run since otherwise the pip logs just drown out the lint messages.
There was a problem hiding this comment.
Reduced to -qq since that's also still non-verbose in 9274c8b. Thanks for the pointer.
| @@ -0,0 +1,36 @@ | |||
| from processor import normalize_images | |||
There was a problem hiding this comment.
Should we add typing to these files?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also: move datafiles in
commonto blob storage.