Conversation
We first want to do a disjunctive query on all names and then add any potential additional filters as a joint conjunction at the end of that.
This is generally useful, e.g. imagine querying for all features in a bounding box or at a particular point but while already having an idea of the names of features that we want to retrieve. Additionally, the feature will be used in the Fortis dashboard for implementing auto-suggest in the place search pane.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's this?
This pull request adds an additional query parameter called
filter_namethat lets users subsample the return values of the featureService to only those features whose name (partially) matches the provided string.This is generally useful, e.g. imagine querying for all features in a bounding box or at a particular point but while already having an idea of the names of features that we want to retrieve. Additionally, the feature will be used in the Fortis dashboard for implementing auto-suggest in the place search pane.
Sample usage
Bounding box query without name filter: 32 results

Narrowing to just features matching "somali": 3 results

Try it live!
Implementation notes
We use the Postgres
strposfunction instead of a wildcardLIKEas it usually leads to better query plans for substring queries. For example, the below query plans show thatstrposis a good 10% faster at execution and 40x faster at planning than the equivalent wildcardLIKE.