Add importer for Divipola datasets #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NodeJS and Postgres differ in how they treat characters like diacritics
when lowercasing so we should always lowercase both sides of our
equality check in the same language.
An example to illustrate the differences:
```
+-------------+------------------------------+----------------+
| Environment | Operation | Result |
+-------------+------------------------------+----------------+
| Postgres | lower('BOGOTÁ, D.C.') | 'bogotÁ, d.c.' |
| NodeJS | 'BOGOTÁ, D.C.'.toLowerCase() | 'bogotá, d.c.' |
+-------------+------------------------------+----------------+
```
After running the importer, we have just under 6k new features in the database.
Most of these features come from the centro-poplado datasets and therewith
represent small towns or cities.
```
features=# select count(*) from features;
count
-------
5879
features=# select count(*), layer from features group by layer order by count desc;
count | layer
-------+----------
4754 | locality
1093 | county
32 | region
```
Unfortunately the Divipola data doesn't give us much additional information on
top of just the name, type and geometry of the features, so additional fields
like population will not be populated in the featureService.
Resolves #14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #14 for background information on this pull request.
Try it live: http://13.72.77.67/features/name/alto%20de%20lisboa
After running the importer, we have just under 6k new features in the database.
Most of these features come from the centro-poplado datasets and therewith
represent small towns or cities.
Unfortunately the Divipola data doesn't give us much additional information on
top of just the name, type and geometry of the features, so additional fields
like population will not be populated in the featureService.
Additionally, this PR also contains fixes for two bugs that were exposed by the
Divipola dataset: lowercasing differences between Postgres and NodeJS and
handling of queries for places with names that contain commas.