Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter for layer #18

Merged
merged 1 commit into from Sep 9, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Sep 8, 2017

This lets us for example exclude all features that are at a too high level (e.g. country or continent) by explicitly specifying all the layers that we care about and only getting results from those layers.

Try it live:

The list of all layer is as follows:

features=# select count(*), layer from features group by layer order by count desc;
 count  |     layer
--------+---------------
 212672 | locality
 118725 | localadmin
  90320 | neighbourhood
  47008 | county
   4996 | region
   4423 | campus
   1666 | microhood
    375 | macrocounty
    351 | macrohood
    228 | country
    138 | borough
    109 | macroregion
     41 | disputed
     39 | dependency
      8 | continent

Knowledge of this list is useful if we only want to exclude particular layers since the features database doesn't have a concept of layer hierarchy at this point. A description of the layers can be found in the Who's on First documentation.

Add filter for layer
This lets us for example exclude all features that are at a too high
level (e.g. country or continent) by explicitly specifying all the
layers that we care about and only getting results from those layers.

@c-w c-w requested review from jcjimenez and erikschlegel Sep 8, 2017

@erikschlegel
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit 7172397 into master Sep 9, 2017

@c-w c-w deleted the filter-layer branch Sep 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.