Harden featureService #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthturner
reviewed
Dec 4, 2017
scripts/install.sh
Outdated
| # setup | ||
| build_dependencies='curl git build-essential' | ||
| sudo apt-get update > /dev/null | ||
| sudo apt-get upgrade > /dev/null |
Member
There was a problem hiding this comment.
Add -y to this line to avoid blocking on user input.
Contributor
Author
There was a problem hiding this comment.
Yep, got it locally, just need to push it.
anthturner
approved these changes
Dec 4, 2017
Member
anthturner
left a comment
anthturner
left a comment
There was a problem hiding this comment.
LGTM.
One minor note is that fail2ban uses iptables by default IIRC, so we should verify that bringing up iptables via fail2ban doesn't overzealously block access to anything else on the server (like the nodejs app).
Contributor
Author
|
Already tried this on a deployment and everything seems to be working fine :) http://fortis-features.eastus.cloudapp.azure.com/features/name/bogota Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See CatalystCode/project-fortis-pipeline#239: