Conversation
In CatalystCode/project-fortis-pipeline#222 we discovered another set of SQL-injection attack vectors for the feature service. This commit fixes potential injection vulnerabilities once and for all by switching all queries to using the postgres built-in parameter interpolation mechanism instead of using string queries. The changes were validated by calling the following routes which should be roughly representative of the entire functionality space of the featureService: ```sh curl 'localhost:8080/features/name/paris' curl 'localhost:8080/features/name/bogota,paris' curl 'localhost:8080/features/id/wof-85971971' curl 'localhost:8080/features/id/wof-404477281,wof-85971971' curl 'localhost:8080/features/point/40.71/74.0' curl 'localhost:8080/features/bbox/47/5/35/10' curl 'localhost:8080/features/bbox/47/5/35/10?filter_name=Saint&filter_layer=campus' ```
Contributor
Author
|
Bringing this to the attention of @stewartadam who found the vulnerability. |
Contributor
|
Thanks Clemens - looks great. |
Contributor
Author
|
Changes merged and deployed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In CatalystCode/project-fortis-pipeline#222 we discovered another set of SQL-injection attack vectors for the feature service. This commit fixes potential injection vulnerabilities once and for all by switching all queries to using the postgres built-in parameter interpolation mechanism instead of using string queries.
The changes were validated by calling the following routes which should be roughly representative of the entire functionality space of the featureService: