Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Postgres error messages #23

Merged
merged 2 commits into from Feb 14, 2018

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Member

commented Feb 13, 2018

According to @anthturner it's not good practice to expose detailed error messages from the database to clients as this makes it easier for an attacker to figure out potential attack vectors.

This pull request masks the Postgres error messages in favor of more generic ones that don't risk leaking sensitive information.

@c-w c-w requested review from anthturner and timfpark Feb 13, 2018

@timfpark

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2018

LGTM!

@anthturner
Copy link
Member

left a comment

LGTM

@c-w c-w merged commit 84bb468 into master Feb 14, 2018

@c-w c-w deleted the hide-errors branch Feb 14, 2018

@c-w c-w referenced this pull request Feb 14, 2018

Closed

Reminder: Security Review #222

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.