Conversation
Also: fix all eslint errors
jcjimenez
reviewed
Feb 15, 2018
Dockerfile
Outdated
| CMD /app/docker-entrypoint.sh | ||
|
|
||
| ENV PORT=80 | ||
| EXPOSE 80 |
Contributor
There was a problem hiding this comment.
Do you know if it's possible to do a EXPOSE $PORT?
Contributor
Author
There was a problem hiding this comment.
Not sure. From the docs/spec it seems like only constants can be exposed. I'll give it a try though and report back.
Contributor
Author
There was a problem hiding this comment.
Yes, seems to work. Good catch. See 453cccc
jcjimenez
approved these changes
Feb 15, 2018
Contributor
jcjimenez
left a comment
jcjimenez
left a comment
There was a problem hiding this comment.
LGTM w/minor question.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of the Fortis security review, we've established that the featureService should be deployed inside of the Fortis kubernetes cluster so that we don't have a single point of failure. More details on this discussion can be found in CatalystCode/project-fortis-pipeline#222 (comment)
In order to enable the featureService to be deployable to kubernetes we must dockerize it. As such, this pull request implements a Dockerfile and entry-point for the featureService that sets up the Node service, sets up the database schema, populates the database from a dump, etc. When starting the service via
docker run, we now get a fully-functional deployment.Additionally, this pull request also implements CD via Travis for the featureService to make it easy for us to publish new Docker images by simply authoring a release on Github. To facilitate the CD, the pull request also implements CI via Travis. Currently the CI just runs eslint so the pull request also includes assorted lint fixes.
I realize that the pull request is quite long, so here are pointers to the core of the new functionality: