Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in getById #7

Merged
merged 2 commits into from
Aug 15, 2017
Merged

Fix bugs in getById #7

merged 2 commits into from
Aug 15, 2017

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Aug 15, 2017

Two fixes:

  1. The controller is defined as /features/id/:id so the ids should come from the params, not the query.
  2. The IN clause should get escaped like ('id1','id2') not ('id1,id2') as previously done.

@c-w c-w requested a review from jcjimenez August 15, 2017 17:41
@c-w c-w changed the title Fix bug in getById Fix bugs in getById Aug 15, 2017
@c-w c-w requested a review from timfpark August 15, 2017 17:51
Copy link

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@c-w c-w merged commit 45ba2a3 into master Aug 15, 2017
@c-w c-w deleted the fix-bug branch August 15, 2017 18:03
@c-w c-w removed the in progress label Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants