Remove assumption that server is run from root - #9
Merged
Merged
Conversation
Previously, reading the deployment_sha file assumed that the server is always run via `node server.js` from the root directory of the service and would crash if this is not the case. In some environments, we may not want to invoke the service in that way, for example because we want to provide an absolute path to the server.js file. This change supports that use-case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, reading the deployment_sha file assumed that the server is always run via
node server.jsfrom the root directory of the service and would crash if this is not the case.In some environments, we may not want to invoke the service in that way, for example because we want to provide an absolute path to the server.js file. This change supports that use-case.