Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove assumption that server is run from root #9

Merged
merged 1 commit into from Sep 7, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Aug 18, 2017

Previously, reading the deployment_sha file assumed that the server is always run via node server.js from the root directory of the service and would crash if this is not the case.

In some environments, we may not want to invoke the service in that way, for example because we want to provide an absolute path to the server.js file. This change supports that use-case.

Remove assumption that server is run from root
Previously, reading the deployment_sha file assumed that the server is
always run via `node server.js` from the root directory of the service
and would crash if this is not the case.
In some environments, we may not want to invoke the service in that way,
for example because we want to provide an absolute path to the server.js
file. This change supports that use-case.

@c-w c-w requested a review from timfpark Aug 18, 2017

@c-w c-w added the in progress label Aug 18, 2017

@jcjimenez
Copy link
Contributor

left a comment

LGTM

@c-w c-w merged commit b348198 into master Sep 7, 2017

@c-w c-w deleted the fix-sha-path branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.