This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Remove unused facts code #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The FactsList component is all we need from the old facts code: - The FactsList gets wired up to the /facts route and then we'll use the same display logic as the ActivityFeed to display fact details on click. - We'll use the DataStore to figure out which pipelines are enabled for the site so that we can organize the facts by pipeline. - We'll use the dashboard services machinery to fetch facts to render on the page.
c-w
force-pushed
the
remove-unused-facts-code
branch
from
db058cb to
f37af4e
Compare
erikschlegel
approved these changes
Oct 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FactsList component is all we need from the old facts code:
The FactsList gets wired up to the /facts route and then we'll use the same display logic as the ActivityFeed to display fact details on click.
We'll use the DataStore to figure out which pipelines are enabled for the site so that we can organize the facts by pipeline.
We'll use the dashboard services machinery to fetch facts to render on the page.