Skip to content
This repository has been archived by the owner. It is now read-only.

Remove unused facts code #100

Merged
merged 1 commit into from Oct 18, 2017
Merged

Remove unused facts code #100

merged 1 commit into from Oct 18, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Oct 16, 2017

The FactsList component is all we need from the old facts code:

  • The FactsList gets wired up to the /facts route and then we'll use the same display logic as the ActivityFeed to display fact details on click.

  • We'll use the DataStore to figure out which pipelines are enabled for the site so that we can organize the facts by pipeline.

  • We'll use the dashboard services machinery to fetch facts to render on the page.

@c-w c-w requested a review from erikschlegel Oct 16, 2017
The FactsList component is all we need from the old facts code:

- The FactsList gets wired up to the /facts route and then we'll use the
  same display logic as the ActivityFeed to display fact details on click.

- We'll use the DataStore to figure out which pipelines are enabled for
  the site so that we can organize the facts by pipeline.

- We'll use the dashboard services machinery to fetch facts to render on
  the page.
@c-w c-w force-pushed the remove-unused-facts-code branch from db058cb to f37af4e Oct 17, 2017
@c-w c-w merged commit a5852b8 into master Oct 18, 2017
2 checks passed
@c-w c-w deleted the remove-unused-facts-code branch Oct 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants