This repository was archived by the owner on Mar 7, 2018. It is now read-only.
Add bare-bones implementation of facts page #101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-w
force-pushed
the
implement-facts-page
branch
from
259b367 to
33b2808
Compare
Smarker
approved these changes
Oct 17, 2017
| const FluxMixin = Fluxxor.FluxMixin(React); | ||
| const StoreWatchMixin = Fluxxor.StoreWatchMixin("FactsStore"); | ||
|
|
||
| export const FactsList = createReactClass({ |
Contributor
There was a problem hiding this comment.
Rather than using createReactClass, could you use class FactsList extends React.Component instead?
Contributor
Author
There was a problem hiding this comment.
Yes definitely that would be a good change. That's a bigger blast-radius than what I'd like to do right now. Will take a note to do this as a follow-up after we progress this feature.
erikschlegel
approved these changes
Oct 17, 2017
| `; | ||
|
|
||
| const variables = { | ||
| pipelinekeys |
Collaborator
There was a problem hiding this comment.
Assuming that event time and keyword tags will also be integrated as variables?
Contributor
Author
There was a problem hiding this comment.
If we do that, how will the view differ from the activity feed?
For now this is just rendering a pinterest-style board of events for all pipelines, in reverse chronological order. We can add more features (like filtering) once we're more stabilized and have a clearer understanding of the requirements of the facts page as compared to the newsfeed component.
c-w
force-pushed
the
implement-facts-page
branch
from
33b2808 to
afb1123
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now this is just rendering a pinterest-style board of events for all pipelines, in reverse chronological order.
We can add more features (like filtering or infinite scroll) once we're more stabilized, collected some real-world data and have a clearer understanding of the requirements of the facts page as compared to the newsfeed component.
Related backend changes: