Skip to content
This repository has been archived by the owner on Mar 7, 2018. It is now read-only.

Add bare-bones implementation of facts page #101

Merged
merged 8 commits into from Nov 28, 2017
Merged

Conversation

c-w
Copy link
Contributor

@c-w c-w commented Oct 17, 2017

For now this is just rendering a pinterest-style board of events for all pipelines, in reverse chronological order.

We can add more features (like filtering or infinite scroll) once we're more stabilized, collected some real-world data and have a clearer understanding of the requirements of the facts page as compared to the newsfeed component.

image

Related backend changes:

Copy link
Contributor

@Smarker Smarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}
};

const FluxMixin = Fluxxor.FluxMixin(React);
const StoreWatchMixin = Fluxxor.StoreWatchMixin("FactsStore");

export const FactsList = createReactClass({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than using createReactClass, could you use class FactsList extends React.Component instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes definitely that would be a good change. That's a bigger blast-radius than what I'd like to do right now. Will take a note to do this as a follow-up after we progress this feature.

`;

const variables = {
pipelinekeys
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming that event time and keyword tags will also be integrated as variables?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do that, how will the view differ from the activity feed?

For now this is just rendering a pinterest-style board of events for all
pipelines, in reverse chronological order.

We can add more features (like filtering) once we're more stabilized and
have a clearer understanding of the requirements of the facts page as
compared to the newsfeed component.
@c-w c-w merged commit 6196805 into master Nov 28, 2017
@c-w c-w deleted the implement-facts-page branch November 28, 2017 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants