Skip to content
This repository has been archived by the owner. It is now read-only.

Add bare-bones implementation of facts page #101

Merged
merged 8 commits into from Nov 28, 2017
Merged

Add bare-bones implementation of facts page #101

merged 8 commits into from Nov 28, 2017

Conversation

@c-w
Copy link
Contributor

@c-w c-w commented Oct 17, 2017

For now this is just rendering a pinterest-style board of events for all pipelines, in reverse chronological order.

We can add more features (like filtering or infinite scroll) once we're more stabilized, collected some real-world data and have a clearer understanding of the requirements of the facts page as compared to the newsfeed component.

image

Related backend changes:

@c-w c-w requested a review from Smarker Oct 17, 2017
@c-w c-w force-pushed the implement-facts-page branch from 259b367 to 33b2808 Oct 17, 2017
Copy link
Contributor

@Smarker Smarker left a comment

LGTM

}
};

const FluxMixin = Fluxxor.FluxMixin(React);
const StoreWatchMixin = Fluxxor.StoreWatchMixin("FactsStore");

export const FactsList = createReactClass({
Copy link
Contributor

@Smarker Smarker Oct 17, 2017

Rather than using createReactClass, could you use class FactsList extends React.Component instead?

Copy link
Contributor Author

@c-w c-w Oct 17, 2017

Yes definitely that would be a good change. That's a bigger blast-radius than what I'd like to do right now. Will take a note to do this as a follow-up after we progress this feature.

`;

const variables = {
pipelinekeys
Copy link
Collaborator

@erikschlegel erikschlegel Oct 17, 2017

Assuming that event time and keyword tags will also be integrated as variables?

Copy link
Contributor Author

@c-w c-w Oct 18, 2017

If we do that, how will the view differ from the activity feed?

For now this is just rendering a pinterest-style board of events for all
pipelines, in reverse chronological order.

We can add more features (like filtering) once we're more stabilized and
have a clearer understanding of the requirements of the facts page as
compared to the newsfeed component.
@c-w c-w force-pushed the implement-facts-page branch from 33b2808 to afb1123 Oct 31, 2017
@c-w c-w merged commit 6196805 into master Nov 28, 2017
2 checks passed
@c-w c-w deleted the implement-facts-page branch Nov 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants